Remove size() method from PositionLinks

trinodb · Nov 4, 2021 · 816596b · 816596b
1 parent 6c20a1a
commit 816596b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/operator/join/ArrayPositionLinks.java b/core/trino-main/src/main/java/io/trino/operator/join/ArrayPositionLinks.java
@@ -69,9 +69,9 @@ public long checksum()
         }
 
         @Override
-        public int size()
+        public boolean isEmpty()
         {
-            return size;
+            return size == 0;
         }
     }
 

diff --git a/core/trino-main/src/main/java/io/trino/operator/join/PositionLinks.java b/core/trino-main/src/main/java/io/trino/operator/join/PositionLinks.java
@@ -48,15 +48,7 @@ interface FactoryBuilder
 
         Factory build();
 
-        /**
-         * @return number of linked elements
-         */
-        int size();
-
-        default boolean isEmpty()
-        {
-            return size() == 0;
-        }
+        boolean isEmpty();
     }
 
     interface Factory

diff --git a/core/trino-main/src/main/java/io/trino/operator/join/SortedPositionLinks.java b/core/trino-main/src/main/java/io/trino/operator/join/SortedPositionLinks.java
@@ -135,9 +135,9 @@ public Factory build()
         }
 
         @Override
-        public int size()
+        public boolean isEmpty()
         {
-            return positionLinks.size();
+            return positionLinks.isEmpty();
         }
 
         // Separate static method to avoid embedding references to "this"