Add comment why disabling pushdown on MariaDB REAL type

trinodb · Dec 19, 2023 · 69315d9 · 69315d9
1 parent 8a3d1f9
commit 69315d9
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java b/plugin/trino-mariadb/src/main/java/io/trino/plugin/mariadb/MariaDbClient.java
@@ -339,6 +339,8 @@ public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connect
             case Types.BIGINT:
                 return Optional.of(bigintColumnMapping());
             case Types.REAL:
+                // Disable pushdown because floating-point values are approximate and not stored as exact values,
+                // attempts to treat them as exact in comparisons may lead to problems
                 return Optional.of(ColumnMapping.longMapping(
                         REAL,
                         (resultSet, columnIndex) -> floatToRawIntBits(resultSet.getFloat(columnIndex)),