Skip to content

Commit

Permalink
Do not set kafka.table-names in tests
Browse files Browse the repository at this point in the history
Kafka in tests is using tables that are injected via KafkaPlugin
constructor and so kafka.tables-names are not used anyway, because
KafkaTableDescriptionSupplier is not used in tests.
  • Loading branch information
kokosing committed Feb 22, 2020
1 parent 293baec commit 6754427
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
*/
package io.prestosql.plugin.kafka;

import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import io.airlift.json.JsonCodec;
Expand Down Expand Up @@ -103,7 +102,6 @@ static DistributedQueryRunner createKafkaQueryRunner(

Map<String, String> kafkaProperties = new HashMap<>(ImmutableMap.copyOf(extraKafkaProperties));
kafkaProperties.putIfAbsent("kafka.nodes", testingKafka.getConnectString());
kafkaProperties.putIfAbsent("kafka.table-names", Joiner.on(",").join(topicDescriptions.keySet()));
kafkaProperties.putIfAbsent("kafka.connect-timeout", "120s");
kafkaProperties.putIfAbsent("kafka.default-schema", "default");
kafkaProperties.putIfAbsent("kafka.messages-per-split", "1000");
Expand Down

0 comments on commit 6754427

Please sign in to comment.