Remove unnecessary variable propagation

trinodb · Sep 17, 2020 · 6149fa2 · 6149fa2
1 parent f9ef95e
commit 6149fa2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSinkProvider.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSinkProvider.java
@@ -61,7 +61,6 @@ public class HivePageSinkProvider
     private final int maxOpenPartitions;
     private final int maxOpenSortFiles;
     private final DataSize writerSortBufferSize;
-    private final boolean immutablePartitions;
     private final LocationService locationService;
     private final ListeningExecutorService writeVerificationExecutor;
     private final JsonCodec<PartitionUpdate> partitionUpdateCodec;
@@ -97,7 +96,6 @@ public HivePageSinkProvider(
         this.maxOpenPartitions = config.getMaxPartitionsPerWriter();
         this.maxOpenSortFiles = config.getMaxOpenSortFiles();
         this.writerSortBufferSize = requireNonNull(config.getWriterSortBufferSize(), "writerSortBufferSize is null");
-        this.immutablePartitions = config.isImmutablePartitions();
         this.locationService = requireNonNull(locationService, "locationService is null");
         this.writeVerificationExecutor = listeningDecorator(newFixedThreadPool(config.getWriteValidationThreads(), daemonThreadsNamed("hive-write-validation-%s")));
         this.partitionUpdateCodec = requireNonNull(partitionUpdateCodec, "partitionUpdateCodec is null");
@@ -157,7 +155,6 @@ private ConnectorPageSink createPageSink(HiveWritableTableHandle handle, boolean
                 pageSorter,
                 writerSortBufferSize,
                 maxOpenSortFiles,
-                immutablePartitions,
                 parquetTimeZone,
                 session,
                 nodeManager,

diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveWriterFactory.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveWriterFactory.java
@@ -136,7 +136,6 @@ public class HiveWriterFactory
     private final int maxOpenSortFiles;
     private final boolean sortedWritingTempStagingPathEnabled;
     private final String sortedWritingTempStagingPath;
-    private final boolean immutablePartitions;
     private final InsertExistingPartitionsBehavior insertExistingPartitionsBehavior;
     private final DateTimeZone parquetTimeZone;
 
@@ -171,7 +170,6 @@ public HiveWriterFactory(
             PageSorter pageSorter,
             DataSize sortBufferSize,
             int maxOpenSortFiles,
-            boolean immutablePartitions,
             DateTimeZone parquetTimeZone,
             ConnectorSession session,
             NodeManager nodeManager,
@@ -200,7 +198,6 @@ public HiveWriterFactory(
         this.maxOpenSortFiles = maxOpenSortFiles;
         this.sortedWritingTempStagingPathEnabled = isTemporaryStagingDirectoryEnabled(session);
         this.sortedWritingTempStagingPath = getTemporaryStagingDirectoryPath(session);
-        this.immutablePartitions = immutablePartitions;
         this.insertExistingPartitionsBehavior = getInsertExistingPartitionsBehavior(session);
         this.parquetTimeZone = requireNonNull(parquetTimeZone, "parquetTimeZone is null");
 
@@ -351,7 +348,6 @@ public HiveWriter createWriter(Page partitionColumns, int position, OptionalInt
                 else {
                     switch (insertExistingPartitionsBehavior) {
                         case APPEND:
-                            checkState(!immutablePartitions);
                             updateMode = UpdateMode.APPEND;
                             writeInfo = locationService.getTableWriteInfo(locationHandle, false);
                             break;
@@ -382,7 +378,6 @@ public HiveWriter createWriter(Page partitionColumns, int position, OptionalInt
             // Write to: an existing partition in an existing partitioned table
             if (insertExistingPartitionsBehavior == InsertExistingPartitionsBehavior.APPEND) {
                 // Append to an existing partition
-                checkState(!immutablePartitions);
                 updateMode = UpdateMode.APPEND;
                 // Check the column types in partition schema match the column types in table schema
                 List<Column> tableColumns = table.getDataColumns();