Do defensive copy of roles when creating Identity

trinodb · Oct 1, 2019 · 5de8fec · 5de8fec
1 parent 2d53c7c
commit 5de8fec
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/presto-spi/src/main/java/io/prestosql/spi/security/Identity.java b/presto-spi/src/main/java/io/prestosql/spi/security/Identity.java
@@ -44,7 +44,7 @@ public Identity(String user, Optional<Principal> principal, Map<String, Selected
     {
         this.user = requireNonNull(user, "user is null");
         this.principal = requireNonNull(principal, "principal is null");
-        this.roles = unmodifiableMap(requireNonNull(roles, "roles is null"));
+        this.roles = unmodifiableMap(new HashMap<>(requireNonNull(roles, "roles is null")));
         this.extraCredentials = unmodifiableMap(new HashMap<>(requireNonNull(extraCredentials, "extraCredentials is null")));
     }