Support range stats on timestamps

trinodb · Jul 21, 2021 · 3ec60e9 · 3ec60e9
1 parent 9884dba
commit 3ec60e9
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 1 deletion.
diff --git a/core/trino-main/src/main/java/io/trino/cost/StatsUtil.java b/core/trino-main/src/main/java/io/trino/cost/StatsUtil.java
@@ -22,8 +22,10 @@
 import io.trino.spi.type.DecimalType;
 import io.trino.spi.type.DoubleType;
 import io.trino.spi.type.IntegerType;
+import io.trino.spi.type.LongTimestamp;
 import io.trino.spi.type.RealType;
 import io.trino.spi.type.SmallintType;
+import io.trino.spi.type.TimestampType;
 import io.trino.spi.type.TinyintType;
 import io.trino.spi.type.Type;
 import io.trino.sql.InterpretedFunctionInvoker;
@@ -46,7 +48,14 @@ static OptionalDouble toStatsRepresentation(Metadata metadata, Session session,
         }
 
         if (DateType.DATE.equals(type)) {
-            return OptionalDouble.of(((Long) value).doubleValue());
+            return OptionalDouble.of((long) value);
+        }
+
+        if (type instanceof TimestampType) {
+            if (((TimestampType) type).isShort()) {
+                return OptionalDouble.of((long) value);
+            }
+            return OptionalDouble.of(((LongTimestamp) value).getEpochMicros());
         }
 
         return OptionalDouble.empty();

diff --git a/core/trino-main/src/main/java/io/trino/sql/rewrite/ShowStatsRewrite.java b/core/trino-main/src/main/java/io/trino/sql/rewrite/ShowStatsRewrite.java
@@ -21,13 +21,15 @@
 import io.trino.cost.SymbolStatsEstimate;
 import io.trino.execution.warnings.WarningCollector;
 import io.trino.metadata.Metadata;
+import io.trino.operator.scalar.timestamp.TimestampToVarcharCast;
 import io.trino.security.AccessControl;
 import io.trino.spi.security.GroupProvider;
 import io.trino.spi.type.BigintType;
 import io.trino.spi.type.DecimalType;
 import io.trino.spi.type.IntegerType;
 import io.trino.spi.type.RealType;
 import io.trino.spi.type.SmallintType;
+import io.trino.spi.type.TimestampType;
 import io.trino.spi.type.TinyintType;
 import io.trino.spi.type.Type;
 import io.trino.sql.QueryUtil;
@@ -72,6 +74,7 @@
 import static io.trino.sql.QueryUtil.simpleQuery;
 import static io.trino.sql.analyzer.TypeSignatureTranslator.toSqlType;
 import static java.lang.Double.isFinite;
+import static java.lang.Math.min;
 import static java.lang.Math.round;
 import static java.util.Objects.requireNonNull;
 
@@ -219,6 +222,12 @@ private static Expression toStringLiteral(Type type, double value)
             if (type.equals(DATE)) {
                 return new StringLiteral(LocalDate.ofEpochDay(round(value)).toString());
             }
+            if (type instanceof TimestampType) {
+                @SuppressWarnings("NumericCastThatLosesPrecision")
+                long epochMicros = (long) value;
+                int outputPrecision = min(((TimestampType) type).getPrecision(), TimestampType.MAX_SHORT_PRECISION);
+                return new StringLiteral(TimestampToVarcharCast.cast(outputPrecision, epochMicros).toStringUtf8());
+            }
             throw new IllegalArgumentException("Unexpected type: " + type);
         }
     }

diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestShowStats.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestShowStats.java
@@ -227,6 +227,45 @@ public void testShowStats()
                         "   (null, null, null, null, 15.0, null, null)");
     }
 
+    @Test
+    public void testShowStatsWithTimestamp()
+    {
+        // precision 0
+        assertQuery(
+                "SHOW STATS FOR (VALUES TIMESTAMP '2021-07-20 16:52:00')",
+                "VALUES " +
+                        "   ('_col0', null, 1, 0, null, '2021-07-20 16:52:00', '2021-07-20 16:52:00'), " +
+                        "   (null, null, null, null, 1, null, null)");
+
+        // precision 3
+        assertQuery(
+                "SHOW STATS FOR (VALUES TIMESTAMP '2021-07-20 16:52:00.123')",
+                "VALUES " +
+                        "   ('_col0', null, 1, 0, null, '2021-07-20 16:52:00.123', '2021-07-20 16:52:00.123'), " +
+                        "   (null, null, null, null, 1, null, null)");
+
+        // precision 6
+        assertQuery(
+                "SHOW STATS FOR (VALUES TIMESTAMP '2021-07-20 16:52:00.123456')",
+                "VALUES " +
+                        "   ('_col0', null, 1, 0, null, '2021-07-20 16:52:00.123456', '2021-07-20 16:52:00.123456'), " +
+                        "   (null, null, null, null, 1, null, null)");
+
+        // precision 9
+        assertQuery(
+                "SHOW STATS FOR (VALUES TIMESTAMP '2021-07-20 16:52:00.123456789')",
+                "VALUES " +
+                        "   ('_col0', null, 1, 0, null, '2021-07-20 16:52:00.123456', '2021-07-20 16:52:00.123456'), " +
+                        "   (null, null, null, null, 1, null, null)");
+
+        // precision 12
+        assertQuery(
+                "SHOW STATS FOR (VALUES TIMESTAMP '2021-07-20 16:52:00.123456789012')",
+                "VALUES " +
+                        "   ('_col0', null, 1, 0, null, '2021-07-20 16:52:00.123456', '2021-07-20 16:52:00.123456'), " +
+                        "   (null, null, null, null, 1, null, null)");
+    }
+
     @Test
     public void testShowStatsWithoutFrom()
     {