Skip to content

Commit

Permalink
Increase timeout in container test
Browse files Browse the repository at this point in the history
When the container healthcheck was added, it also replaced looping
over trino-cli in the container test script with docker inspect.
Since executing trino-cli could time out after the container started
but before the server was ready, it actually added to the total timeout
of the loop. Now, none of the commands in the loop are blocking for
longer periods, so the timeout is easier to control.

It was measured that the container can take up to 7 minutes to start on arm64
using emulation, so the timeout is raised to 10 minutes.
  • Loading branch information
nineinchnick authored and findepi committed Mar 2, 2022
1 parent 7f1bb80 commit 3a64e70
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/docker/container-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function cleanup {

function test_trino_starts {
local QUERY_PERIOD=10
local QUERY_RETRIES=30
local QUERY_RETRIES=60

CONTAINER_ID=
trap cleanup EXIT
Expand Down

0 comments on commit 3a64e70

Please sign in to comment.