Skip to content

Commit

Permalink
Reproduce Hive concurrency issue
Browse files Browse the repository at this point in the history
testBad() fails on TestHiveInMemoryMetastore with:

java.lang.IllegalStateException: Query already begun: Optional[20200306_080241_00002_adgin] while starting query 20200306_080241_00003_adgin

	at com.google.common.base.Preconditions.checkState(Preconditions.java:823)
	at io.prestosql.plugin.hive.metastore.SemiTransactionalHiveMetastore.beginQuery(SemiTransactionalHiveMetastore.java:999)
	at io.prestosql.plugin.hive.HiveMetadata.beginQuery(HiveMetadata.java:2367)
	at io.prestosql.plugin.hive.AbstractTestHive.testBad(AbstractTestHive.java:954)
  • Loading branch information
rzeyde-varada committed Mar 6, 2020
1 parent ff9a971 commit 33950b1
Showing 1 changed file with 33 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -925,6 +925,39 @@ public void close()
}
}

@Test
public void testGood()
{
try (Transaction transaction = newTransaction()) {
ConnectorMetadata metadata = transaction.getMetadata();

ConnectorSession first = newSession();
metadata.beginQuery(first);
metadata.cleanupQuery(first);

ConnectorSession second = newSession();
metadata.beginQuery(second);
metadata.cleanupQuery(second);
}
}

@Test
public void testBad()

This comment has been minimized.

Copy link
@rzeyde-varada

rzeyde-varada Mar 6, 2020

Author Contributor

Fails after #1034

{
try (Transaction transaction = newTransaction()) {
ConnectorMetadata metadata = transaction.getMetadata();

ConnectorSession first = newSession();
ConnectorSession second = newSession();

metadata.beginQuery(first);
metadata.beginQuery(second);

metadata.cleanupQuery(first);
metadata.cleanupQuery(second);
}
}

@Test
public void testGetDatabaseNames()
{
Expand Down

0 comments on commit 33950b1

Please sign in to comment.