Use UNNECESSARY as default rounding mode

Major motivation for the change is fact that UNNECESSARY rounding mode is more conservative (safer) than HALF_UP.
trinodb · May 28, 2020 · 2fad53f · 2fad53f
1 parent 8b4e165
commit 2fad53f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/presto-oracle/src/main/java/io/prestosql/plugin/oracle/OracleConfig.java b/presto-oracle/src/main/java/io/prestosql/plugin/oracle/OracleConfig.java
@@ -27,7 +27,7 @@ public class OracleConfig
 {
     private boolean synonymsEnabled;
     private Integer defaultNumberScale;
-    private RoundingMode numberRoundingMode = RoundingMode.HALF_UP;
+    private RoundingMode numberRoundingMode = RoundingMode.UNNECESSARY;
 
     @NotNull
     public boolean isSynonymsEnabled()

diff --git a/presto-oracle/src/test/java/io/prestosql/plugin/oracle/TestOracleConfig.java b/presto-oracle/src/test/java/io/prestosql/plugin/oracle/TestOracleConfig.java
@@ -35,7 +35,7 @@ public void testDefaults()
         assertRecordedDefaults(recordDefaults(OracleConfig.class)
                 .setSynonymsEnabled(false)
                 .setDefaultNumberScale(null)
-                .setNumberRoundingMode(RoundingMode.HALF_UP));
+                .setNumberRoundingMode(RoundingMode.UNNECESSARY));
     }
 
     @Test