Test directory lister with hive paths with characters to be escaped

trinodb · Jul 27, 2023 · 2f513f6 · 2f513f6
1 parent 539d63b
commit 2f513f6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/...n/trino-hive-hadoop2/src/test/java/io/trino/plugin/hive/AbstractTestHiveFileSystemS3.java b/...n/trino-hive-hadoop2/src/test/java/io/trino/plugin/hive/AbstractTestHiveFileSystemS3.java
@@ -170,6 +170,10 @@ public void testFileIteratorPartitionedListingNativeS3Client()
         //             nested-file.txt
         //      part=plus+sign/
         //          plus-file.txt
+        //      part=percent%sign/
+        //          percent-file.txt
+        //      part=url%20encoded/
+        //          url-encoded-file.txt
         //      part=level1|level2/
         //          pipe-file.txt
         //          parent1/
@@ -186,6 +190,8 @@ public void testFileIteratorPartitionedListingNativeS3Client()
         createFile(writableBucket, format("%s/part=nested/parent/_nested-hidden-file.txt", basePrefix));
         createFile(writableBucket, format("%s/part=nested/parent/nested-file.txt", basePrefix));
         createFile(writableBucket, format("%s/part=plus+sign/plus-file.txt", basePrefix));
+        createFile(writableBucket, format("%s/part=percent%%sign/percent-file.txt", basePrefix));
+        createFile(writableBucket, format("%s/part=url%%20encoded/url-encoded-file.txt", basePrefix));
         createFile(writableBucket, format("%s/part=level1|level2/pipe-file.txt", basePrefix));
         createFile(writableBucket, format("%s/part=level1|level2/parent1/parent2/deeply-nested-file.txt", basePrefix));
         createFile(writableBucket, format("%s/part=level1 | level2/pipe-blanks-file.txt", basePrefix));
@@ -209,6 +215,8 @@ public void testFileIteratorPartitionedListingNativeS3Client()
                 format("%s/part=simple/plain-file.txt", basePath),
                 format("%s/part=nested/parent/nested-file.txt", basePath),
                 format("%s/part=plus+sign/plus-file.txt", basePath),
+                format("%s/part=percent%%sign/percent-file.txt", basePath),
+                format("%s/part=url%%20encoded/url-encoded-file.txt", basePath),
                 format("%s/part=level1|level2/pipe-file.txt", basePath),
                 format("%s/part=level1|level2/parent1/parent2/deeply-nested-file.txt", basePath),
                 format("%s/part=level1 | level2/pipe-blanks-file.txt", basePath));

diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHiveFileSystem.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHiveFileSystem.java
@@ -536,6 +536,10 @@ public void testFileIteratorPartitionedListing()
         //             nested-file.txt
         //      part=plus+sign/
         //          plus-file.txt
+        //      part=percent%sign/
+        //          percent-file.txt
+        //      part=url%20encoded/
+        //          url-encoded-file.txt
         //      part=level1|level2/
         //          pipe-file.txt
         //          parent1/
@@ -567,6 +571,12 @@ public void testFileIteratorPartitionedListing()
         // create file in `part=plus+sign` non-hidden folder (which contains `+` special character)
         Path plainFilePartitionPlusSign = new Path(new Path(basePath, "part=plus+sign"), "plus-file.txt");
         fs.createNewFile(plainFilePartitionPlusSign);
+        // create file in `part=percent%sign` non-hidden folder (which contains `%` special character)
+        Path plainFilePartitionPercentSign = new Path(new Path(basePath, "part=percent%sign"), "percent-file.txt");
+        fs.createNewFile(plainFilePartitionPercentSign);
+        // create file in `part=url%20encoded` non-hidden folder (which contains `%` special character)
+        Path plainFilePartitionUrlEncoded = new Path(new Path(basePath, "part=url%20encoded"), "url-encoded-file.txt");
+        fs.createNewFile(plainFilePartitionUrlEncoded);
         // create file in `part=level1|level2` non-hidden folder (which contains `|` special character)
         Path plainFilePartitionPipeSign = new Path(new Path(basePath, "part=level1|level2"), "pipe-file.txt");
         fs.createNewFile(plainFilePartitionPipeSign);
@@ -601,6 +611,8 @@ public void testFileIteratorPartitionedListing()
                 plainFilePartitionSimple,
                 nestedFilePartitionNested,
                 plainFilePartitionPlusSign,
+                plainFilePartitionPercentSign,
+                plainFilePartitionUrlEncoded,
                 plainFilePartitionPipeSign,
                 deeplyNestedFilePartitionPipeSign,
                 plainFilePartitionPipeSignBlanks);