Support setting column comments in ClickHouse

trinodb · Jan 18, 2022 · 242bbba · 242bbba
1 parent 7bf8da9
commit 242bbba
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/docs/src/main/sphinx/connector/clickhouse.rst b/docs/src/main/sphinx/connector/clickhouse.rst
@@ -190,5 +190,6 @@ statements, the connector supports the following features:
 * :doc:`/sql/create-schema`
 * :doc:`/sql/drop-schema`
 * :doc:`/sql/alter-schema`
+* :doc:`/sql/comment`
 
 .. include:: alter-schema-limitation.fragment
diff --git a/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java b/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
@@ -315,6 +315,17 @@ public void renameColumn(ConnectorSession session, JdbcTableHandle handle, JdbcC
         }
     }
 
+    @Override
+    public void setColumnComment(ConnectorSession session, JdbcTableHandle handle, JdbcColumnHandle column, Optional<String> comment)
+    {
+        String sql = format(
+                "ALTER TABLE %s COMMENT COLUMN %s '%s'",
+                quoted(handle.asPlainTable().getRemoteTableName()),
+                quoted(column.getColumnName()),
+                comment.orElse(""));
+        execute(session, sql);
+    }
+
     @Override
     public ResultSet getTables(Connection connection, Optional<String> schemaName, Optional<String> tableName)
             throws SQLException

diff --git a/...rino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java b/...rino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
@@ -78,7 +78,6 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
                 return false;
 
             case SUPPORTS_COMMENT_ON_TABLE:
-            case SUPPORTS_COMMENT_ON_COLUMN:
                 return false;
 
             case SUPPORTS_ARRAY: