Skip to content

Commit

Permalink
Deprecate iceberg.materialized-views.storage-schema property
Browse files Browse the repository at this point in the history
The recommended way of handling storage tables is to have `iceberg.materialized-views.hide-storage-table` set to true, and not use `iceberg.materialized-views.storage-schema`. `iceberg.materialized-views.hide-storage-table` is already deprecated. We should stick with the default behavior of hiding the storage table from end users, and not having to set a schema for storing them.
  • Loading branch information
anusudarsan authored and ebyhr committed Dec 10, 2024
1 parent f100c35 commit 1f2249b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
9 changes: 1 addition & 8 deletions docs/src/main/sphinx/connector/iceberg.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,6 @@ implementation is used:
* - `iceberg.hive-catalog-name`
- Catalog to redirect to when a Hive table is referenced.
-
* - `iceberg.materialized-views.storage-schema`
- Schema for creating materialized views storage tables. When this property is
not configured, storage tables are created in the same schema as the
materialized view definition. When the `storage_schema` materialized view
property is specified, it takes precedence over this catalog property.
- Empty
* - `iceberg.register-table-procedure.enabled`
- Enable to allow user to call [`register_table` procedure](iceberg-register-table).
- `false`
Expand Down Expand Up @@ -1677,8 +1671,7 @@ WITH ( format = 'ORC', partitioning = ARRAY['event_date'] )
```

By default, the storage table is created in the same schema as the materialized
view definition. The `iceberg.materialized-views.storage-schema` catalog
configuration property or `storage_schema` materialized view property can be
view definition. The `storage_schema` materialized view property can be
used to specify the schema where the storage table is created.

Creating a materialized view does not automatically populate it with data. You
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -407,12 +407,14 @@ public IcebergConfig setHideMaterializedViewStorageTable(boolean hideMaterialize
return this;
}

@Deprecated
@NotNull
public Optional<String> getMaterializedViewsStorageSchema()
{
return materializedViewsStorageSchema;
}

@Deprecated
@Config("iceberg.materialized-views.storage-schema")
@ConfigDescription("Schema for creating materialized views storage tables")
public IcebergConfig setMaterializedViewsStorageSchema(String materializedViewsStorageSchema)
Expand Down

0 comments on commit 1f2249b

Please sign in to comment.