Skip to content

Commit

Permalink
Clean up code comments in JdbcJoinPushdownUtil
Browse files Browse the repository at this point in the history
  • Loading branch information
raunaqmorarka authored and losipiuk committed Jun 19, 2024
1 parent ab70abe commit 1b0a011
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public static Optional<PreparedQuery> implementJoinCostAware(
}

/**
* Common implementation of AUTOMATIC join pushdown strategy to by used in SEP Jdbc connectors
* Common implementation of AUTOMATIC join pushdown strategy used in Jdbc connectors
*/
public static boolean shouldPushDownJoinCostAware(
ConnectorSession session,
Expand Down Expand Up @@ -106,9 +106,9 @@ public static boolean shouldPushDownJoinCostAware(

double joinDataSize = statistics.getJoinStatistics().get().getDataSize();
if (joinDataSize < getJoinPushdownAutomaticJoinToTablesRatio(session) * (leftDataSize + rightDataSize)) {
// This is poor man's estimation if it makes more sense to perform join in source database or SEP.
// The assumption here is that cost of performing join in source database is less than or equal to cost of join in SEP.
// We resolve tie for pessimistic case (both join costs equal) on cost of sending the data from source database to SEP.
// This is poor man's estimation if it makes more sense to perform join in source database or Trino.
// The assumption here is that cost of performing join in source database is less than or equal to cost of join in Trino.
// We resolve tie for pessimistic case (both join costs equal) on cost of sending the data from source database to Trino.
LOG.debug("triggering join pushdown for %s", joinSignature);
return true;
}
Expand Down

0 comments on commit 1b0a011

Please sign in to comment.