Skip to content

Commit

Permalink
Remove fallback to interpreter for JoinCompiler
Browse files Browse the repository at this point in the history
  • Loading branch information
dain committed Oct 7, 2020
1 parent 9e6e36f commit 1232d39
Showing 1 changed file with 9 additions and 14 deletions.
23 changes: 9 additions & 14 deletions presto-main/src/main/java/io/prestosql/operator/PagesIndex.java
Original file line number Diff line number Diff line change
Expand Up @@ -493,20 +493,15 @@ public LookupSourceSupplier createLookupSourceSupplier(
// This code path will trigger only for OUTER joins. To fix that we need to add support for
// OUTER joins into NestedLoopsJoin and remove "type == INNER" condition in LocalExecutionPlanner.visitJoin()

try {
LookupSourceSupplierFactory lookupSourceFactory = joinCompiler.compileLookupSourceFactory(types, joinChannels, sortChannel, outputChannels);
return lookupSourceFactory.createLookupSourceSupplier(
session,
valueAddresses,
channels,
hashChannel,
filterFunctionFactory,
sortChannel,
searchFunctionFactories);
}
catch (Exception e) {
log.error(e, "Lookup source compile failed for types=%s error=%s", types, e);
}
LookupSourceSupplierFactory lookupSourceFactory = joinCompiler.compileLookupSourceFactory(types, joinChannels, sortChannel, outputChannels);
return lookupSourceFactory.createLookupSourceSupplier(
session,
valueAddresses,
channels,
hashChannel,
filterFunctionFactory,
sortChannel,
searchFunctionFactories);
}

// if compilation fails
Expand Down

0 comments on commit 1232d39

Please sign in to comment.