Remove unused return value from Iceberg catalog methods

trinodb · Feb 18, 2022 · 0790a5a · 0790a5a
1 parent df0a16e
commit 0790a5a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TrinoCatalog.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TrinoCatalog.java
@@ -46,7 +46,7 @@ public interface TrinoCatalog
 {
     List<String> listNamespaces(ConnectorSession session);
 
-    boolean dropNamespace(ConnectorSession session, String namespace);
+    void dropNamespace(ConnectorSession session, String namespace);
 
     Map<String, Object> loadNamespaceMetadata(ConnectorSession session, String namespace);
 
@@ -68,7 +68,7 @@ Transaction newCreateTableTransaction(
             String location,
             Map<String, String> properties);
 
-    boolean dropTable(ConnectorSession session, SchemaTableName schemaTableName, boolean purgeData);
+    void dropTable(ConnectorSession session, SchemaTableName schemaTableName, boolean purgeData);
 
     void renameTable(ConnectorSession session, SchemaTableName from, SchemaTableName to);
 

diff --git a/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TrinoHiveCatalog.java b/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TrinoHiveCatalog.java
@@ -211,7 +211,7 @@ public void createNamespace(ConnectorSession session, String namespace, Map<Stri
     }
 
     @Override
-    public boolean dropNamespace(ConnectorSession session, String namespace)
+    public void dropNamespace(ConnectorSession session, String namespace)
     {
         // basic sanity check to provide a better error message
         if (!listTables(session, Optional.of(namespace)).isEmpty() ||
@@ -239,7 +239,6 @@ public boolean dropNamespace(ConnectorSession session, String namespace)
         }).orElse(deleteSchemaLocationsFallback);
 
         metastore.dropDatabase(namespace, deleteData);
-        return true;
     }
 
     @Override
@@ -296,7 +295,7 @@ public List<SchemaTableName> listTables(ConnectorSession session, Optional<Strin
     }
 
     @Override
-    public boolean dropTable(ConnectorSession session, SchemaTableName schemaTableName, boolean purgeData)
+    public void dropTable(ConnectorSession session, SchemaTableName schemaTableName, boolean purgeData)
     {
         // TODO: support path override in Iceberg table creation: https://github.com/trinodb/trino/issues/8861
         Table table = loadTable(session, schemaTableName);
@@ -306,7 +305,6 @@ public boolean dropTable(ConnectorSession session, SchemaTableName schemaTableNa
             throw new TrinoException(NOT_SUPPORTED, "Table " + schemaTableName + " contains Iceberg path override properties and cannot be dropped from Trino");
         }
         metastore.dropTable(schemaTableName.getSchemaName(), schemaTableName.getTableName(), purgeData);
-        return true;
     }
 
     @Override