Skip to content

Commit

Permalink
Test NULL handling compatibility for partition values
Browse files Browse the repository at this point in the history
  • Loading branch information
findinpath committed Jul 20, 2023
1 parent b9f4848 commit 0542056
Showing 1 changed file with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,10 @@ public void testPartitionedInsertCompatibility()
try {
onDelta().executeQuery("INSERT INTO default." + tableName + " VALUES (1,'ala'), (2, 'kota')");
onDelta().executeQuery("INSERT INTO default." + tableName + " VALUES (3, 'osla')");
onDelta().executeQuery("INSERT INTO default." + tableName + " VALUES (null, 'mysz')");
onTrino().executeQuery("INSERT INTO delta.default." + tableName + " VALUES (3, 'psa'), (4, 'bobra')");
onTrino().executeQuery("INSERT INTO delta.default." + tableName + " VALUES (4, 'lwa'), (5, 'jeza')");
onTrino().executeQuery("INSERT INTO delta.default." + tableName + " VALUES (null, 'kon')");

List<Row> expectedRows = ImmutableList.of(
row(1, "ala"),
Expand All @@ -118,12 +120,18 @@ public void testPartitionedInsertCompatibility()
row(3, "psa"),
row(4, "bobra"),
row(4, "lwa"),
row(5, "jeza"));
row(5, "jeza"),
row(null, "mysz"),
row(null, "kon"));

assertThat(onDelta().executeQuery("SELECT * FROM default." + tableName))
.containsOnly(expectedRows);
assertThat(onTrino().executeQuery("SELECT * FROM delta.default." + tableName))
.containsOnly(expectedRows);

assertThat(onTrino().executeQuery("SELECT \"$path\" FROM delta.default." + tableName + " WHERE a_number IS NULL").column(1))
.hasSize(2)
.allMatch(path -> ((String) path).contains("/a_number=__HIVE_DEFAULT_PARTITION__/"));
}
finally {
dropDeltaTableWithRetry("default." + tableName);
Expand Down

0 comments on commit 0542056

Please sign in to comment.