Improve logs for HTTP event listener

trinodb · Feb 23, 2022 · 02fa8b4 · 02fa8b4
1 parent b33fccf
commit 02fa8b4
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/.../trino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListener.java b/.../trino-http-event-listener/src/main/java/io/trino/plugin/httpquery/HttpEventListener.java
@@ -144,12 +144,17 @@ public void onSuccess(StatusResponse result)
                                                 result.getStatusCode(), nextDelay.roundTo(TimeUnit.SECONDS));
 
                                         attemptToSend(request, nextAttempt, nextDelay, queryId);
-                                        return;
+                                    }
+                                    else {
+                                        log.error("QueryId = \"%s\", attempt = %d/%d, URL = %s | Ingest server responded with code %d, fatal error",
+                                                queryId, attempt + 1, config.getRetryCount() + 1, request.getUri().toString(),
+                                                result.getStatusCode());
                                     }
                                 }
-
-                                log.debug("QueryId = \"%s\", attempt = %d/%d, URL = %s | Query event delivered successfully",
-                                        queryId, attempt + 1, config.getRetryCount() + 1, request.getUri().toString());
+                                else {
+                                    log.debug("QueryId = \"%s\", attempt = %d/%d, URL = %s | Query event delivered successfully",
+                                            queryId, attempt + 1, config.getRetryCount() + 1, request.getUri().toString());
+                                }
                             }
 
                             @Override
@@ -164,11 +169,11 @@ public void onFailure(Throwable t)
                                             nextDelay.roundTo(TimeUnit.SECONDS));
 
                                     attemptToSend(request, nextAttempt, nextDelay, queryId);
-                                    return;
                                 }
-
-                                log.error(t, "QueryId = \"%s\", attempt = %d/%d, URL = %s | Error sending HTTP request",
-                                        queryId, attempt + 1, config.getRetryCount() + 1, request.getUri().toString());
+                                else {
+                                    log.error(t, "QueryId = \"%s\", attempt = %d/%d, URL = %s | Error sending HTTP request",
+                                            queryId, attempt + 1, config.getRetryCount() + 1, request.getUri().toString());
+                                }
                             }
                         }, executor),
                 (long) delay.getValue(), delay.getUnit());