Fix creating non-bucketed empty partition

Fix a bug where creating empty parition using CALL statement throws exceptions when using file based metastore implementation. Extracted-From: prestodb/presto#11376
trinodb · Jan 29, 2019 · 00aa33b · 00aa33b
1 parent 120c28f
commit 00aa33b
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
@@ -1228,6 +1228,13 @@ public Optional<ConnectorOutputMetadata> finishInsert(ConnectorSession session,
         Map<List<String>, ComputedStatistics> partitionComputedStatistics = createComputedStatisticsToPartitionMap(computedStatistics, partitionedBy, columnTypes);
 
         for (PartitionUpdate partitionUpdate : partitionUpdates) {
+            if (partitionUpdate.getFileNames().size() == 0) {
+                HiveWriteUtils.createDirectory(
+                        new HdfsContext(session, table.get().getDatabaseName(), table.get().getTableName()),
+                        hdfsEnvironment,
+                        partitionUpdate.getWritePath());
+            }
+
             if (partitionUpdate.getName().isEmpty()) {
                 // insert into unpartitioned table
                 metastore.finishInsertIntoExistingTable(

diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/TestHiveIntegrationSmokeTest.java
@@ -944,6 +944,30 @@ public void testCastNullToColumnTypes()
         assertUpdate("DROP TABLE " + tableName);
     }
 
+    @Test
+    public void testCreateEmptyPartition()
+    {
+        String tableName = "empty_partition_table";
+        assertUpdate(format("" +
+                "CREATE TABLE %s " +
+                "WITH ( " +
+                " FORMAT = 'ORC', " +
+                "   partitioned_by = ARRAY['p_varchar'] " +
+                ") " +
+                "AS " +
+                "SELECT c_bigint, p_varchar " +
+                "FROM ( " +
+                "  VALUES " +
+                "    (BIGINT '7', 'longlonglong')" +
+                ") AS x (c_bigint, p_varchar)", tableName), 1);
+        assertQuery(format("SELECT count(*) FROM \"%s$partitions\"", tableName), "SELECT 1");
+
+        // create an empty partition
+        assertUpdate(format("CALL system.create_empty_partition('%s', '%s', ARRAY['p_varchar'], ARRAY['%s'])", TPCH_SCHEMA, tableName, "empty"));
+        assertQuery(format("SELECT count(*) FROM \"%s$partitions\"", tableName), "SELECT 2");
+        assertUpdate("DROP TABLE " + tableName);
+    }
+
     @Test
     public void testCreateEmptyBucketedPartition()
     {