Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #594

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Remove unused code #594

merged 1 commit into from
Jan 20, 2025

Conversation

oneonestar
Copy link
Member

Description

Remove unused code.

Additional context and related issues

Forgot to remove the dead code when refactoring from while loop to ScheduledExecutorService in #533.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 20, 2025
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha .. nice catch. Maybe we should do a search for Thread.sleep overall.

@mosabua mosabua merged commit 99677f7 into trinodb:main Jan 20, 2025
2 checks passed
@github-actions github-actions bot added this to the 14 milestone Jan 20, 2025
@oneonestar oneonestar deleted the star/unused_code branch January 20, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants