Remove trailing slash in proxyTo and externalUrl in create and update backend methods #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Dec 14, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/router/TestHaGatewayManager.java
Show resolved
Hide resolved
willmostly
reviewed
Jan 7, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
Outdated
Show resolved
Hide resolved
|
@willmostly @ebyhr can you please review. |
ebyhr
reviewed
Jan 20, 2025
gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
Outdated
Show resolved
Hide resolved
|
Please squash commits into one. |
prakhar10
force-pushed
the
trailing-slash-issue
branch
from
edffc7d to
ea5058d
Compare
|
@ebyhr can you check now please? |
Please remove the commit body. |
prakhar10
force-pushed
the
trailing-slash-issue
branch
from
ea5058d to
e0a6092
Compare
willmostly
approved these changes
Jan 21, 2025
ebyhr
reviewed
Jan 22, 2025
| @@ -94,19 +94,23 @@ public void activateBackend(String backendName) | |||
| @Override | |||
| public ProxyBackendConfiguration addBackend(ProxyBackendConfiguration backend) | |||
| { | |||
| dao.create(backend.getName(), backend.getRoutingGroup(), backend.getProxyTo(), backend.getExternalUrl(), backend.isActive()); | |||
| String backendProxyTo = removeTrailingSlash(backend.getProxyTo()); | |||
| String backendExternalUrl = removeTrailingSlash(backend.getExternalUrl()); | |||
There was a problem hiding this comment.
These getters are called from other places. Please check all usages. For instance, The following place has the same issue because UI_LOGIN_PATH is /ui/login.
There was a problem hiding this comment.
So the way I was thinking about this is to remove the slash while saving a new backend or updating a new backend so that later on any method that pulls this will always get the correct url from the database instead of trimming it in every part of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove trailing slash in proxyTo and externalUrl in create and update backend methods. Fixes #564
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(X) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: