Inject OAuth2GatewayCookie #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
force-pushed
the
will/inject-cookie-configuration
branch
from
4a4db41 to
afbb9a1
Compare
ebyhr
reviewed
Oct 31, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/router/OAuth2GatewayCookie.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/OAuth2GatewayCookieProvider.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/OAuth2GatewayCookieProvider.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/main/java/io/trino/gateway/ha/router/OAuth2GatewayCookieProvider.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/inject-cookie-configuration
branch
from
afbb9a1 to
cb97cee
Compare
ebyhr
reviewed
Nov 1, 2024
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class OAuth2GatewayCookieProvider |
There was a problem hiding this comment.
I'm not sure why we need a new class as the logic is pretty simple. Why not putting deletePaths & ttl on fields in ProxyRequestHandler?
There was a problem hiding this comment.
We could do this. It seemed cleaner to keep the oauth2 cookie configuration out of ProxyRequestHandler since it does not use it directly. How do you typically draw the line between injecting vs plumbing configuration properties through by hand?
willmostly
force-pushed
the
will/inject-cookie-configuration
branch
from
cb97cee to
69054ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use injection to configure and provide OAuth2GatewayCookie.
Additional context and related issues
OAuth2GatewayCookie is configured in a non-standard way due to the previous usage of Dropwizard. This
can be refactored to use normal injection. There should be no functional changes as a result of this PR.
Release notes
( x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: