Add Trino configuration docs #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mosabua
force-pushed
the
trino-config
branch
2 times, most recently
from
fbf4133 to
e6dcb1f
Compare
willmostly
approved these changes
Apr 12, 2024
| scenarios, where the local URL of the Trino cluster is private to the Trino | ||
| cluster on the DNS/network level, these following calls might not work at all | ||
| for users. | ||
|
|
There was a problem hiding this comment.
This setting is also required for Trino to authenticate in the case TLS is terminated at the Trino Gateway. Normally it refuses to authenticate plain HTTP requests, but if http-server.process-forwarded=true it will authenticate over HTTP if the request includes X-Forwarded-Proto: HTTPS. I doubt this is a common set up, but perhaps worth mentioning.
There was a problem hiding this comment.
Good point... I added this as well. Maybe we should also add to Trino docs honestly.. hahah
There was a problem hiding this comment.
I will create a ticket to do that .. just looked .. the docs for that in Trino are bad..
- with process forwarding config only for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OAuth2 and other tips will follow in separate PRs from @willmostly and others.
Additional context and related issues
Replaces #217
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.