Update TestNG to version 7 #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trino is only using TestNG in product tests so this change is contained and should not cause issues
kokosing
reviewed
Jul 4, 2024
| @@ -1,5 +1,10 @@ | |||
| FROM ghcr.io/trinodb/testing/centos7-oj11:53 | |||
There was a problem hiding this comment.
The below is workaround, can we move to almalinux instead?
There was a problem hiding this comment.
Once we release new images, sure!
| @@ -42,6 +42,7 @@ | |||
| <air.check.skip-pmd>true</air.check.skip-pmd> | |||
|
|
|||
| <project.build.targetJdk>21</project.build.targetJdk> | |||
| <dep.testng.version>7.10.2</dep.testng.version> | |||
There was a problem hiding this comment.
Trino should not care is it does not use testng
There was a problem hiding this comment.
It does use. As testng is part of product tests. So maybe I should use different words. Does product tests are passing in Trino with this change? I guess we will find out after the release :)
losipiuk
approved these changes
Jul 4, 2024
kokosing
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trino is only using TestNG in product tests so this change is contained and should not cause issues