Upgrade to Java 17 and use getPlatformClassLoader for jar parameter #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
changed the title
|
Why not move to 17? |
ebyhr
changed the title
|
@ebyhr the class loader change is gone and commit message is out of sync now |
|
@wendigo CI is green now. |
|
@ebyhr please extract docker bump to a separate commit. other than that LGTM |
wendigo
approved these changes
Jul 26, 2023
|
Docker bump is directly related to the change because CI doesn't pass with |
|
@ebyhr fine, I wasn't aware :) |
|
Oh, right, higher java version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trinodb/trino#17667 is trying to download jar from maven programatically and use
jarparameter, butJdbcUtils.class.getClassLoader()caused class loader issue.