Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JWT Access Token Authentication Option #268

Closed
wants to merge 22 commits into from

Conversation

jschroth
Copy link
Member

Added option for Access Token and updated trino-go-client to v0.318.0

Copy link

cla-bot bot commented Oct 22, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Oct 22, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Oct 23, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Oct 23, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Oct 23, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Oct 24, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented Oct 31, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Oct 31, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick
Copy link
Member

Also, please rebase, we updated the Trino Go driver in another PR that was just merged.

@cla-bot cla-bot bot added the cla-signed label Nov 1, 2024
@jschroth
Copy link
Member Author

jschroth commented Nov 1, 2024

@nineinchnick thanks for the review. I think I addressed your comments. I also made the fields in UI a little more consistent.

I was not sure if I should update the CHANGELOG.md and package.json as recommended in the DEVELOPMENT.md file, but please let me know if you want me to do those things as well.

@nineinchnick
Copy link
Member

@jschroth please rebase and I can merge this. You could update the CHANGELOG.md and package.json too, but I would handle this anyway.

kalil-pelissier and others added 6 commits November 5, 2024 19:27
- Update grafana-plugin-sdk-go to solve security vulnerability
- Update Go toolchain to the latest version
- Update library usages to accommodate updated APIs
- Update the plugin version
@jschroth jschroth force-pushed the feat/access_token_auth branch from 7851113 to 8211911 Compare November 5, 2024 19:28
@jschroth
Copy link
Member Author

jschroth commented Nov 5, 2024

Git is being very strange I feel like this whole PR is now messed up. I am going to try opening a new one from main with the hope that it fixes whatever the rebase issue is.

@jschroth jschroth closed this Nov 5, 2024
@jschroth
Copy link
Member Author

jschroth commented Nov 5, 2024

Moved to #274

@jschroth jschroth deleted the feat/access_token_auth branch November 5, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants