Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Maven cache from default branch #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nineinchnick
Copy link
Member

Allow to use cache from the default branch even when there are changes in any pom files.

Allow to use cache from the default branch even when there are changes in
any pom files.
@nineinchnick
Copy link
Member Author

@hashhar this is the equivalent of trinodb/trino#14882

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remind why this needs to live external to the repo?

@nineinchnick
Copy link
Member Author

Because it first checks out sources so actions included in those sources are not available. There's no point in splitting this into two actions because the additional steps are closely related - they validate that the checked-out commit is valid.

@hashhar
Copy link
Member

hashhar commented Nov 15, 2022

The benefit of being able to iterate together and not having to find all references to action + updating the ref is considerable IMO.

Just moving the checkout to main repo makes it possible to bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants