-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding worker autoscaling support with KEDA #277
base: main
Are you sure you want to change the base?
Conversation
For some reason, the @nineinchnick I am open to suggestions for a better metric or testing strategy. |
35dc778
to
b9dcd3b
Compare
52c79e9
to
757de90
Compare
I found the I am also wondering if the Chart should support the creation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, I haven't yet checked all the new properties.
charts/trino/values.yaml
Outdated
@@ -114,6 +114,70 @@ server: | |||
# selectPolicy: Max | |||
# ``` | |||
|
|||
# -- Configure [KEDA](https://keda.sh/) for workers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should document this is exclusive with server.autoscaling
, and if possible, help users make the choice, if they're just starting with autoscaling and don't know either one of those options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes totally sense. I will improve the documentation on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to clarify this in the documentation. I also added a warning in NOTES.txt to indicate that keda would take precedente over hpa in case they are both enabled.
757de90
to
d20836f
Compare
No description provided.