Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in Trino JMX documentation #276

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

sdaberdaku
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Dec 12, 2024
@sdaberdaku sdaberdaku force-pushed the fix/jmx-documentation-typo branch from 12655de to 65b6d20 Compare December 12, 2024 09:09
@sdaberdaku
Copy link
Member Author

@nineinchnick I figured out why the tests are failing. The Chart in the tests references the latest JMX exporter docker image which is broken.

@nineinchnick
Copy link
Member

Let's pin it to the last working version, can you add it as a separate commit in this PR?

@sdaberdaku
Copy link
Member Author

Let's pin it to the last working version, can you add it as a separate commit in this PR?

sure thing!

@sdaberdaku sdaberdaku marked this pull request as ready for review December 12, 2024 11:49
@sdaberdaku
Copy link
Member Author

@nineinchnick tests are working again now!

@nineinchnick nineinchnick added the documentation Improvements or additions to documentation label Dec 12, 2024
@nineinchnick nineinchnick merged commit e007f42 into trinodb:main Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

2 participants