add session property #156
add session property #156
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
1 similar comment
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -173,6 +173,31 @@ resourceGroups: {} | |||
| # ] | |||
| # } | |||
|
|
|||
| sessionPropertyConfig: {} | |||
There was a problem hiding this comment.
@joshuasu-async sorry for the delay. I recently added a more complete test in https://github.com/trinodb/charts/blob/main/test-values.yaml. Can you update it to enable this config so we know this works correctly?
Also, please rebase and see the updated way of formatting examples here. We now include them in the README, so they should be formatted using Markdown.
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: trino-session-property-config-volume-coordinator |
There was a problem hiding this comment.
I'm not sure historically as to why some config is deployed to a new configmap while everything else (node.properties, jvm.config etc) is deployed into a single configmap?
However if a separate configmap is still desired, please avoid hardcoding the name and instead make use of a template function? See the naming used for the main configmap and the example in #170 and #109 .
It is helpful (for testing etc) to be able to ensure that multiple trino instances can be deployed into a single namespace.
|
I'm closing it since there has been no activity here for a few months now. |
No description provided.