Adds documentation for the name overrides

trinodb · May 24, 2024 · e692064 · e692064
1 parent e398138
commit e692064
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml
@@ -2,6 +2,13 @@
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
 
+# If you want to have multiple Trino Clusters in same namespace 
+# override the following values to avoid naming conflicts
+# Example:
+# coordinatorNameOverride: trino-adhoc 
+# workerNameOverride: trino-adhoc  
+# nameOverride: trino-adhoc
+
 image:
   # -- Image registry, defaults to empty, which results in DockerHub usage
   registry: ""

diff --git a/test.sh b/test.sh
@@ -6,7 +6,7 @@ declare -A testCases=(
     [default]=""
     [single_node]="--set server.workers=0"
     [complete_values]="--values test-values.yaml"
-    [multiple_clusters]="--set coordinatorNameOverride=overriden --set workerNameOverride=overriden --set nameOverride=overriden"
+    [multiple_clusters]="--set coordinatorNameOverride=overriden,workerNameOverride=overriden,nameOverride=overriden"
 )
 
 function join_by {
@@ -82,12 +82,12 @@ for test_name in "${TEST_NAMES[@]}"; do
     echo "🧪 Running test $test_name"
     echo "${testCases[$test_name]}"
     if [ "$test_name" == "multiple_clusters" ]; then
-        time ct install "${CT_ARGS[@]}" --helm-extra-set-args "$HELM_EXTRA_SET_ARGS ${testCases[default]}"
+        time ct install "${CT_ARGS[@]}" --helm-extra-set-args "$HELM_EXTRA_SET_ARGS ${testCases[default]}" --skip-clean-up
         time ct install "${CT_ARGS[@]}" --helm-extra-set-args "$HELM_EXTRA_SET_ARGS ${testCases[$test_name]}"
     else
         time ct install "${CT_ARGS[@]}" --helm-extra-set-args "$HELM_EXTRA_SET_ARGS ${testCases[$test_name]}"
     fi
-    
+
     echo "Test $test_name completed"
 done