Add support for image registry and digest

trinodb · Feb 27, 2024 · c42bd2e · c42bd2e
1 parent 2c1d97b
commit c42bd2e
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 5 deletions.
diff --git a/charts/trino/templates/_helpers.tpl b/charts/trino/templates/_helpers.tpl
@@ -92,3 +92,26 @@ Create the name of the service account to use
 {{- default "default" .Values.serviceAccount.name }}
 {{- end }}
 {{- end }}
+
+{{/*
+Return the proper image name
+{{ include "trino.image" . }}
+
+Code is inspired from bitnami/common
+
+*/}}
+{{- define "trino.image" -}}
+{{- $registryName := .Values.image.registry -}}
+{{- $repositoryName := .Values.image.repository -}}
+{{- $separator := ":" -}}
+{{- $termination := (default .Chart.AppVersion .Values.image.tag) | toString -}}
+{{- if .Values.image.digest }}
+  {{- $separator = "@" -}}
+  {{- $termination = .Values.image.digest | toString -}}
+{{- end -}}
+{{- if $registryName }}
+  {{- printf "%s/%s%s%s" $registryName $repositoryName $separator $termination -}}
+{{- else -}}
+  {{- printf "%s%s%s"  $repositoryName $separator $termination -}}
+{{- end -}}
+{{- end -}}
diff --git a/charts/trino/templates/deployment-coordinator.yaml b/charts/trino/templates/deployment-coordinator.yaml
@@ -97,7 +97,7 @@ spec:
         {{- toYaml .Values.imagePullSecrets | nindent 8 }}
       containers:
         - name: {{ .Chart.Name }}-coordinator
-          image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+          image: {{ include "trino.image" . }}
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
             {{- toYaml .Values.env | nindent 12 }}

diff --git a/charts/trino/templates/deployment-worker.yaml b/charts/trino/templates/deployment-worker.yaml
@@ -75,7 +75,7 @@ spec:
         {{- toYaml .Values.imagePullSecrets | nindent 8 }}
       containers:
         - name: {{ .Chart.Name }}-worker
-          image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
+          image: {{ include "trino.image" . }}
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           env:
             {{- toYaml .Values.env | nindent 12 }}

diff --git a/charts/trino/values.yaml b/charts/trino/values.yaml
@@ -3,11 +3,13 @@
 # Declare variables to be passed into your templates.
 
 image:
-  repository: trinodb/trino
-  pullPolicy: IfNotPresent
+  registry: ""   # Trino image registry
+  repository: trinodb/trino    # Trind image repository
   # Overrides the image tag whose default is the chart version.
   # Same value as Chart.yaml#appVersion
-  tag: 432
+  tag: ""   # Trino image tag. Default is appVersion from Chart.yaml
+  digest: ""   # Trino image digest as `sha256:abcd...`. Please note this parameter, if set, will override the tag
+  pullPolicy: IfNotPresent
 
 imagePullSecrets:
   - name: registry-credentials