forked from astral-sh/ruff
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary Bandit now also reports `B113` on `httpx` (PyCQA/bandit#1060). This PR implements the same logic, to detect missing or `None` timeouts for `httpx` alongside `requests`. ## Test Plan Snapshot tests.
- Loading branch information
1 parent
a184f84
commit 8210c1e
Showing
3 changed files
with
388 additions
and
122 deletions.
There are no files selected for viewing
62 changes: 55 additions & 7 deletions
62
crates/ruff_linter/resources/test/fixtures/flake8_bandit/S113.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,71 @@ | ||
import httpx | ||
import requests | ||
|
||
# OK | ||
requests.get('https://gmail.com', timeout=5) | ||
requests.post('https://gmail.com', timeout=5) | ||
requests.put('https://gmail.com', timeout=5) | ||
requests.delete('https://gmail.com', timeout=5) | ||
requests.patch('https://gmail.com', timeout=5) | ||
requests.options('https://gmail.com', timeout=5) | ||
requests.head('https://gmail.com', timeout=5) | ||
|
||
httpx.get('https://gmail.com', timeout=5) | ||
httpx.post('https://gmail.com', timeout=5) | ||
httpx.put('https://gmail.com', timeout=5) | ||
httpx.delete('https://gmail.com', timeout=5) | ||
httpx.patch('https://gmail.com', timeout=5) | ||
httpx.options('https://gmail.com', timeout=5) | ||
httpx.head('https://gmail.com', timeout=5) | ||
httpx.Client(timeout=5) | ||
httpx.AsyncClient(timeout=5) | ||
with httpx.Client(timeout=5) as client: | ||
client.get('https://gmail.com') | ||
async def foo(): | ||
async with httpx.AsyncClient(timeout=5) as client: | ||
await client.get('https://gmail.com') | ||
|
||
# Errors | ||
requests.get('https://gmail.com') | ||
requests.get('https://gmail.com', timeout=None) | ||
requests.get('https://gmail.com', timeout=5) | ||
requests.post('https://gmail.com') | ||
requests.post('https://gmail.com', timeout=None) | ||
requests.post('https://gmail.com', timeout=5) | ||
requests.put('https://gmail.com') | ||
requests.put('https://gmail.com', timeout=None) | ||
requests.put('https://gmail.com', timeout=5) | ||
requests.delete('https://gmail.com') | ||
requests.delete('https://gmail.com', timeout=None) | ||
requests.delete('https://gmail.com', timeout=5) | ||
requests.patch('https://gmail.com') | ||
requests.patch('https://gmail.com', timeout=None) | ||
requests.patch('https://gmail.com', timeout=5) | ||
requests.options('https://gmail.com') | ||
requests.options('https://gmail.com', timeout=None) | ||
requests.options('https://gmail.com', timeout=5) | ||
requests.head('https://gmail.com') | ||
requests.head('https://gmail.com', timeout=None) | ||
requests.head('https://gmail.com', timeout=5) | ||
|
||
httpx.get('https://gmail.com') | ||
httpx.get('https://gmail.com', timeout=None) | ||
httpx.post('https://gmail.com') | ||
httpx.post('https://gmail.com', timeout=None) | ||
httpx.put('https://gmail.com') | ||
httpx.put('https://gmail.com', timeout=None) | ||
httpx.delete('https://gmail.com') | ||
httpx.delete('https://gmail.com', timeout=None) | ||
httpx.patch('https://gmail.com') | ||
httpx.patch('https://gmail.com', timeout=None) | ||
httpx.options('https://gmail.com') | ||
httpx.options('https://gmail.com', timeout=None) | ||
httpx.head('https://gmail.com') | ||
httpx.head('https://gmail.com', timeout=None) | ||
httpx.Client() | ||
httpx.Client(timeout=None) | ||
httpx.AsyncClient() | ||
httpx.AsyncClient(timeout=None) | ||
with httpx.Client() as client: | ||
client.get('https://gmail.com') | ||
with httpx.Client(timeout=None) as client: | ||
client.get('https://gmail.com') | ||
async def bar(): | ||
async with httpx.AsyncClient() as client: | ||
await client.get('https://gmail.com') | ||
async def baz(): | ||
async with httpx.AsyncClient(timeout=None) as client: | ||
await client.get('https://gmail.com') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.