Use memset_s to clear auth password. #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
reviewed
Aug 14, 2023
| @@ -417,7 +418,7 @@ int trilogy_auth_switch_send(trilogy_conn_t *conn, const trilogy_handshake_t *ha | |||
| void trilogy_auth_clear_password(trilogy_conn_t *conn) | |||
| { | |||
| if (conn->socket->opts.password) { | |||
| memset(conn->socket->opts.password, 0, conn->socket->opts.password_len); | |||
| memset_s(conn->socket->opts.password, conn->socket->opts.password_len, 0, conn->socket->opts.password_len); | |||
There was a problem hiding this comment.
This function is not always defined, so it would need a detection mechanism to see if it's available.
There was a problem hiding this comment.
yup realized too late that memset_s is not in posix. I believe explicit_bzero would be the alternative. Need to do an if def to handle this 😑
There is a possibility that memset is optimised away, which would be problematic when clearing the password. Thus we replace memset with memset_s which has a far stricter language preventing this optimisation.
if memset_s is not available use explict_bzero instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility that memset is optimised away, which would be problematic when clearing the password. Thus we replace memset with memset_s which has a far stricter language preventing this optimisation.
fixes #103