Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade videojs to v7 #49

Merged
merged 6 commits into from
Nov 22, 2019
Merged

Upgrade videojs to v7 #49

merged 6 commits into from
Nov 22, 2019

Conversation

jackpope
Copy link
Contributor

@jackpope jackpope commented Aug 22, 2019 •
edited
Loading

Fixes #46

  • Move to yarn for package management
  • Upgrade videojs to v7.6.0 Support for video js 7 #46
  • Update Circle ci config to use node 10.15.2
  • Fixes gulp build from no-oping
  • Add semantic-release git
  • Remove build files from version control

@jackpope jackpope mentioned this pull request Oct 27, 2019
Closed
@aaackerman
Copy link
Contributor

@jackpope do you need any eyes on new changes or help wrt testing?

@jackpope
Copy link
Contributor Author

@aaackerman I should have some time tomorrow to look this over again and fix the dev watch command. I'll re-request your review when it is ready for another look. Thanks!

@drichar
Copy link
Contributor

drichar commented Nov 12, 2019

We're using videojs v7 and evaluating this for our core product. It looks to be exactly what we need. Let us know if we can help to get it merged!

@jackpope jackpope mentioned this pull request Nov 15, 2019
Closed
@jackpope jackpope requested a review from aaackerman November 22, 2019 16:16
@jackpope jackpope merged commit d15d9ef into master Nov 22, 2019
@jackpope jackpope deleted the upgrade-videojs branch November 22, 2019 21:19
@contentlyrobot
Copy link

🎉 This PR is included in version 1.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@drichar
Copy link
Contributor

drichar commented Nov 22, 2019

Thank you!! 🎉🎉

@jackpope
Copy link
Contributor Author

@drichar just a note on this release, somehow my BREAKING CHANGE commit messages didn't get picked up by semantic-release. I'm trying to move things around to get this out at v2.0.0 as there are breaking changes. Will update here when done.

@jackpope
Copy link
Contributor Author

I've published v2.0.0 to npm and tagged here on github.

The v1.1.5 release has been removed.

Cheers! 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BARK-STEEL BARK-STEEL BARK-STEEL approved these changes

@aaackerman aaackerman Awaiting requested review from aaackerman

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for video js 7
5 participants
@jackpope @aaackerman @drichar @contentlyrobot @BARK-STEEL