Skip to content

Commit

Permalink
op-node: Reduce weight and cap for p2p sync error responses.
Browse files Browse the repository at this point in the history
Previously these were capped to prevent peers being banned on this measure alone, but they could be downscored enough to ignore gossip from them. While p2p alt sync is not widely enabled we need to keep peers that don't support it and so significantly reduce this weighting.
  • Loading branch information
ajsutton committed Jul 11, 2023
1 parent d8d41bc commit c80a3ee
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions op-node/p2p/app_params.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ func LightApplicationScoreParams(cfg *rollup.Config) ApplicationScoreParams {
ValidResponseWeight: 0.5,
ValidResponseDecay: ScoreDecay(tenEpochs, slot),

// Takes 20 error responses to reach the default ban threshold of -100
// But at most we track 10. These errors include not supporting p2p sync
// so we don't (yet) want to ban a peer based on this measure alone.
ErrorResponseCap: 10,
ErrorResponseWeight: -5,
// Takes 10 error responses to reach the default gossip threshold of -10
// But at most we track 9. These errors include not supporting p2p sync
// so we don't (yet) want to ignore gossip from a peer based on this measure alone.
ErrorResponseCap: 9,
ErrorResponseWeight: -1,
ErrorResponseDecay: ScoreDecay(tenEpochs, slot),

// Takes 5 rejected payloads to reach the default ban threshold of -100
Expand Down

0 comments on commit c80a3ee

Please sign in to comment.