Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update batch page #571

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Update batch page #571

merged 4 commits into from
Nov 22, 2023

Conversation

asiia-trilitech
Copy link
Contributor

@asiia-trilitech asiia-trilitech commented Nov 20, 2023 •
edited
Loading

Proposed changes

  • Rename "Confirm Batch" button to "Submit Batch"
  • Update padding of AccountSmallTileDisplay to match the mocks
  • Update button text & dialog text on DeleteBatch confirmation dialog

Task link

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

  • Add some transactions to a batch
  • Go to Batch page
  • Try deleting a batch

Screenshots

  • Before:
Screenshot 2023-11-21 at 14 52 51 Screenshot 2023-11-21 at 14 53 00
  • Now
Screenshot 2023-11-21 at 14 52 17 Screenshot 2023-11-21 at 14 52 27

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@asiia-trilitech asiia-trilitech marked this pull request as ready for review November 21, 2023 14:55
serjonya-trili
serjonya-trili approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@serjonya-trili serjonya-trili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things in comments, but other than that 👍

src/components/AccountSelector/AccountSmallTile.tsx Outdated Show resolved Hide resolved
src/components/AccountSelector/AccountSmallTile.tsx Outdated Show resolved Hide resolved
src/components/AccountSelector/AccountSmallTileDisplay.tsx Outdated Show resolved Hide resolved
@asiia-trilitech asiia-trilitech merged commit 61cce0c into main Nov 22, 2023
2 checks passed
@asiia-trilitech asiia-trilitech deleted the update-batch-page branch November 22, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serjonya-trili serjonya-trili serjonya-trili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asiia-trilitech @serjonya-trili