Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address UI feedback part1 #515

Merged
merged 18 commits into from
Oct 24, 2023
Merged

Address UI feedback part1 #515

merged 18 commits into from
Oct 24, 2023

Conversation

serjonya-trili
Copy link
Contributor

@serjonya-trili serjonya-trili commented Oct 19, 2023 •
edited
Loading

Proposed changes

Task link

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Before Now
Screenshot 2023-10-19 at 11 02 12 Screenshot 2023-10-19 at 11 02 05
Screenshot 2023-10-19 at 11 05 10 Screenshot 2023-10-19 at 11 05 01
Screenshot 2023-10-19 at 11 05 18 Screenshot 2023-10-19 at 11 02 53
Screenshot 2023-10-19 at 11 05 18 Screenshot 2023-10-19 at 11 02 47
Screenshot 2023-10-19 at 11 19 41 Screenshot 2023-10-19 at 11 19 35
Screenshot 2023-10-19 at 11 45 23 Screenshot 2023-10-19 at 11 44 40
Screenshot 2023-10-19 at 11 45 26 Screenshot 2023-10-19 at 11 44 43

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@serjonya-trili serjonya-trili force-pushed the address-ui-feedback-part1 branch 5 times, most recently from 6c90a50 to d42ee94 Compare October 23, 2023 09:00
@serjonya-trili serjonya-trili marked this pull request as draft October 23, 2023 09:00
@serjonya-trili serjonya-trili force-pushed the address-ui-feedback-part1 branch 2 times, most recently from 5db1bbf to da2ad17 Compare October 23, 2023 12:28
@serjonya-trili serjonya-trili force-pushed the address-ui-feedback-part1 branch from c4cadf2 to 82c234d Compare October 24, 2023 10:15
@serjonya-trili serjonya-trili marked this pull request as ready for review October 24, 2023 10:15
ryutamago
ryutamago reviewed Oct 24, 2023
View reviewed changes
src/assets/icons/ExternalLink.tsx Outdated

export default ExternalLinkIcon;

// <g clip-path="url(#clip0_3490_44754)">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this :)

@serjonya-trili serjonya-trili force-pushed the address-ui-feedback-part1 branch from 82c234d to bcfaecb Compare October 24, 2023 10:48
@serjonya-trili serjonya-trili force-pushed the address-ui-feedback-part1 branch from bcfaecb to b87c0b2 Compare October 24, 2023 10:52
@serjonya-trili serjonya-trili merged commit 53591c2 into main Oct 24, 2023
2 checks passed
@serjonya-trili serjonya-trili deleted the address-ui-feedback-part1 branch October 24, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryutamago ryutamago ryutamago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serjonya-trili @ryutamago