Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get icons pt1 #459

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Remove get icons pt1 #459

merged 5 commits into from
Sep 26, 2023

Conversation

ryutamago
Copy link
Contributor

@ryutamago ryutamago commented Sep 25, 2023

This is the first step of removing the getIcons related components. It reuses the AddressTile components and hooks to reduce duplicated logic.

  • Make AddressTileIcon take two sizes: "md" and "lg"
  • Add the AccountTileIcon component that is used in the MultisigSignerTile now
  • Refactored the MultisigSignerTile
  • Removed the MultisigSignerTileDisplay

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Before Now
Screenshot 2023-09-26 at 11 58 29 Screenshot 2023-09-26 at 11 26 22

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@ryutamago ryutamago marked this pull request as ready for review September 26, 2023 03:26
@ryutamago ryutamago merged commit 3917377 into main Sep 26, 2023
@ryutamago ryutamago deleted the remove-get-icons-pt1 branch September 26, 2023 10:34
@ryutamago ryutamago mentioned this pull request Sep 27, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants