Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WalletConnect integration, part 9, get accounts #2288

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dianasavvatina
Copy link
Contributor

Proposed changes

Implemented tezos_getAccounts

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Example with https://www.fxhash.xyz/

  1. goto https://www.fxhash.xyz/
  2. in top right corner - menu - connect - connext XTZ wallet - show more -show qr code - walletconnect - copy
  3. connect to account not revealed on mainnet
  4. see error toast: Signer address is not revealed on the mainnet
image

Example with Tezos provider dapp example

  1. install dapp
  2. connect to umami
  3. Get accounts
  4. See the toast at Umami:
image 5. see the outcome at dapp: ``` [ { "algo": "ed25519", "address": "tz1Q78RciND3VPD39fxq3rqBnry5qgyxzSdA", "pubkey": "edpkuD2a1fHPnFTm9kbDTb4DagZ8H6XbHUdrxsfzCZpDgUyEFrTjiL" } ] ```

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:45pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:45pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:45pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:45pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant