Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WalletConnect, reject proposal if no supported network #2287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dianasavvatina
Copy link
Contributor

Proposed changes

Fixed handling of session proposal request via WalletConnect if the required network list is not supported.
Now using WalletConnectError exception and sending the response properly.

Previously the response was not sent to the dapp.

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

  1. go to https://dappradar.com/
  2. click Connect -> WalletConnect -> copy link
  3. try to connect in Umami
  4. See toast on Umami:
    The requested required network "eip155:1" is not supported. Available: tezos:mainnet,tezos:ghostnet
  5. See toast on dappradar
    Login with WalletConnect Failed. Please check your wallet notifications and try again.

Screenshots

Add the screenshots of how the app used to look like and how it looks now
image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:52am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:52am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:52am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:52am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant