fix: Error: No matching request found (on Beacon sign)

[dianasavvatina]

Proposed changes

Fixed error on successful sign request:

Uncaught (in promise) Error: No matching request found!

The problem is that on successful sign, SignPayloadRequestModal calls onClose() which is intended to handle the situation when a user closes the modal window effectively rejecting the request. Since the sign is already approved, an attempt to reject the request results in this error. The logic is the same in web and desktop:

• web: https://github.com/trilitech/umami-v2/blob/main/apps/web/src/components/beacon/useHandleBeaconMessage.tsx#L91
• desktop: https://github.com/trilitech/umami-v2/blob/main/apps/desktop/src/utils/beacon/useHandleBeaconMessage.tsx#L90

The error is not shown after the change.

Types of changes

• Bugfix
• New feature
• Refactor
• Breaking change
• UI fix

Steps to reproduce

1. connect wallet with https://taquito-test-dapp.pages.dev/
2. sign payload
3. check the log for the error Error: No matching request found!

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Before:

Checklist

• Tests that prove my fix is effective or that my feature works have been added
• Documentation has been added (if appropriate)
• Screenshots are added (if any UI changes have been made)
• All TODOs have a corresponding task created (and the link is attached to it)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
umami-embed-iframe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 4:49pm
umami-embed-iframe-ghostnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 4:49pm
umami-v2-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 4:49pm
umami-v2-web-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 18, 2024 4:49pm