Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social login 2fa warning #2234

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Add social login 2fa warning #2234

merged 3 commits into from
Dec 10, 2024

Conversation

OKendigelyan
Copy link
Contributor

@OKendigelyan OKendigelyan commented Dec 10, 2024 •
edited
Loading

Proposed changes

This PR adds SocialLoginWarning to alert user about 2fa importance and implements sequential call to the warning modals

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Screenshots

image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:14pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:14pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:14pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:14pm

@OKendigelyan OKendigelyan force-pushed the add-social-logic-2fa-warning branch from 3e42d9e to b5cfb67 Compare December 10, 2024 19:03
@OKendigelyan OKendigelyan marked this pull request as ready for review December 10, 2024 19:09
@OKendigelyan OKendigelyan force-pushed the add-social-logic-2fa-warning branch from b5cfb67 to eca2f21 Compare December 10, 2024 19:13
@OKendigelyan OKendigelyan force-pushed the add-social-logic-2fa-warning branch from eca2f21 to f8b2bca Compare December 10, 2024 20:55
@ajinkyaraj-23 ajinkyaraj-23 self-requested a review December 10, 2024 21:05
ajinkyaraj-23
ajinkyaraj-23 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the tests , rest lgtm

@OKendigelyan OKendigelyan merged commit 4263bbc into main Dec 10, 2024
10 checks passed
@OKendigelyan OKendigelyan deleted the add-social-logic-2fa-warning branch December 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

@asiia-trilitech asiia-trilitech Awaiting requested review from asiia-trilitech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OKendigelyan @ajinkyaraj-23