Migrate data from umami old version to new version #2215
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/desktop/public/electron.js
Outdated
| @@ -223,7 +247,10 @@ function start() { | |||
| // This method will be called when Electron has finished its initialization and | |||
| // is ready to create the browser windows. | |||
| // Some APIs can only be used after this event occurs. | |||
| app.whenReady().then(createWindow); | |||
| app.whenReady().then(async () => { | |||
| await readAndCopyValues(); | |||
There was a problem hiding this comment.
Should this be called every time the app is open?
Would it be possible to check if the user data is absent & only then copy it (so readAndCopyValues() only runs once)?
Will log out work properly?
We should make sure to clear both dbs on logout to avoid repopulating db with the old data
There was a problem hiding this comment.
Right now its called everytime the app is open. I believe that will rewrite old data again and again. I can change it like follows:
once the data is copied i can delete old data. Then there is no problem?
There was a problem hiding this comment.
Also consider creating a backup for old data. This allows for recovery in case the migration encounters unforeseen issues.
There was a problem hiding this comment.
once the data is copied i can delete old data. Then there is no problem?
Good idea, @ajinkyaraj-23
However, migrating back to the older version would result in no user data - we should check with Aswin if that's something we're OK with
There was a problem hiding this comment.
Right that's a good question.
apps/desktop/public/electron.js
Outdated
| async function readAndCopyValues() { | ||
| try { | ||
| const accountsValue = await db.get("_file://\x00\x01persist:accounts"); | ||
| const rootValue = await db.get("_file://\x00\x01persist:root"); |
There was a problem hiding this comment.
We should migrate all the data present in the existing (old) DB, not just root and accounts
There was a problem hiding this comment.
Why?
following are the keys which are generated:
Key: b'_devtools://devtools\x00\x01experiments', Value : b'\x01{}'
Key: b'_devtools://devtools\x00\x01localInspectorVersion', Value : b'\x0137'
Key: b'_file://\x00\x01beacon:matrix-selected-node', Value : b'\x01beacon-node-1.hope-5.papers.tech'
Key: b'_file://\x00\x01beacon:sdk-matrix-preserved-state', Value : b'\x01{"syncToken":"s44195095_1_0_1_1_1_1_2556620_1","rooms":{}}'
Key: b'_file://\x00\x01beacon:sdk-secret-seed', Value : b'\x019eca6480-5621-54a9-7c26-9d5cc062bc9f'
Key: b'_file://\x00\x01beacon:sdk_version', Value : b'\x014.2.2'
Key: b'_file://\x00\x01chakra-ui-color-mode', Value : b'\x01dark'
Key: b'_file://\x00\x01loglevel:broadcast-channel', Value : b'\x01ERROR'
Key: b'_file://\x00\x01loglevel:customauth', Value : b'\x01SILENT'
Key: b'_file://\x00\x01loglevel:fnd', Value : b'\x01SILENT'
Key: b'_file://\x00\x01loglevel:http-helpers', Value : b'\x01INFO'
Key: b'_file://\x00\x01loglevel:torus.js', Value : b'\x01SILENT'
Key: b'_file://\x00\x01persist:accounts'
There was a problem hiding this comment.
To keep the same functionality as the previous version and lose nothing
There was a problem hiding this comment.
We only backup these two keys in backup so i guess, this is good enough, other keys need not be copied and we can still keep the same functionality. Rather trying to copy everything causes more errors.
There was a problem hiding this comment.
What about Key: b'_file://\x00\x01loglevel:customauth', Value : b'\x01SILENT' - I believe that's dApp connections, they should be preserved on update I think
There was a problem hiding this comment.
I think that will be enough for this fix, but any other flags or keys on the client side will be lost
OKendigelyan
force-pushed
the
2195-updating-umami-should-not-lead-to-re-iimporting-all-my-accounts
branch
from
b8779cc to
570c4d8
Compare
ajinkyaraj-23
force-pushed
the
2195-updating-umami-should-not-lead-to-re-iimporting-all-my-accounts
branch
from
570c4d8 to
5e7b427
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
OKendigelyan
force-pushed
the
2195-updating-umami-should-not-lead-to-re-iimporting-all-my-accounts
branch
from
2b25461 to
ec28b26
Compare
OKendigelyan
force-pushed
the
2195-updating-umami-should-not-lead-to-re-iimporting-all-my-accounts
branch
from
ec28b26 to
3b4da04
Compare
OKendigelyan
force-pushed
the
2195-updating-umami-should-not-lead-to-re-iimporting-all-my-accounts
branch
from
827f0bd to
12e5b90
Compare
OKendigelyan
had a problem deploying
to
Production – umami-v2
GitHub Actions
Failure
OKendigelyan
had a problem deploying
to
Production – umami-v2
GitHub Actions
Failure
OKendigelyan
had a problem deploying
to
Production – umami-v2
GitHub Actions
Failure
Proposed changes
(Specific to umami desktop version)
Due to addition of custom protocol in apps/desktop/public/electron.js, the localstorage key structure changed from file:// to app://assets thus the data of accounts etc. was not being visible in the upgraded version (2.3.4)
Added a logic to migrate the existing data from old key to new keys in leveldb.
Types of changes
Steps to reproduce
Upgrade to 2.3.4 and data from previous version disappers.
| Before | Now |
To test build a production grade packaged app and replace it over existing 2.3.3 version app. The data should be visible.
Checklist