Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set new Tezos RPC nodes #2163

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Set new Tezos RPC nodes #2163

merged 4 commits into from
Dec 3, 2024

Conversation

asiia-trilitech
Copy link
Contributor

@asiia-trilitech asiia-trilitech commented Nov 27, 2024 •
edited by OKendigelyan
Loading

Proposed changes

Issues were found related to the RPX nodes we ='re using at the moment. We're switching to new nodes controlled by ECAD labs.

Security review task link #48
Security review task link #47

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:17pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:17pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:17pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:17pm

@OKendigelyan OKendigelyan marked this pull request as ready for review December 2, 2024 17:49
@OKendigelyan OKendigelyan force-pushed the update-rpc-nodes branch 2 times, most recently from f7f6901 to 591721e Compare December 3, 2024 13:02
asiia-trilitech
asiia-trilitech commented Dec 3, 2024
View reviewed changes
Copy link
Contributor Author

@asiia-trilitech asiia-trilitech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change @OKendigelyan!

I think the node urls was just updated to https://mainnet.tezos.ecadinfra.com/ & https://ghostnet.tezos.ecadinfra.com/ - might be for the best to just go with the new ones to avoid changes in the future
https://taquito.io/docs/rpc_nodes/

And please check the comments for some questions 🙁

Overall code looks good - let me check how embed is working and get back to you

apps/embed-iframe-mainnet/vercel.json Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it just changed to https://mainnet.tezos.ecadinfra.com & https://ghostnet.tezos.ecadinfra.com/?

https://taquito.io/docs/rpc_nodes/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the changelog here https://github.com/ecadlabs/taquito/releases/tag/20.1.1

apps/web/src/components/MasterPasswordModal/MasterPasswordModal.test.tsx
await user.click(screen.getByRole("button", { name: "Submit" }));
},
{
timeout: 5000,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need timeout here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried act like in the other tests?

packages/state/src/migrations.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the migration

apps/web/src/setupTests.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why test setup was changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test changes fix flaky tests timeout issues and some other issues related to axios

@asiia-trilitech asiia-trilitech requested review from ajinkyaraj-23 and removed request for ajinkyaraj-23 December 3, 2024 15:19
ajinkyaraj-23
ajinkyaraj-23 reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the ecad rpc url to latest format.

@ajinkyaraj-23 ajinkyaraj-23 self-requested a review December 3, 2024 15:53
ajinkyaraj-23
ajinkyaraj-23 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@OKendigelyan OKendigelyan merged commit a5901f2 into main Dec 3, 2024
9 of 10 checks passed
@OKendigelyan OKendigelyan deleted the update-rpc-nodes branch December 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OKendigelyan OKendigelyan OKendigelyan left review comments

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asiia-trilitech @ajinkyaraj-23 @OKendigelyan