Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build workflow on all platforms #2116

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

ajinkyaraj-23
Copy link
Collaborator

Proposed changes

Build the apps for all platforms (windows, linux and mac) on github CI.
Task link

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Add the screenshots of how the app used to look like and how it looks now

Before Now

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Nov 18, 2024
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:07pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:07pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:07pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 2:07pm

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@add-ci branch 3 times, most recently from 740aaa9 to 897ad2d Compare November 20, 2024 17:21
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

run: cd apps/desktop

- name: electron-publish-linux
run: CI=true GH_TOKEN=${{ secrets.github_token }} pnpm run electron:package:linux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate key called env for this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted.

@vercel vercel bot temporarily deployed to Preview – umami-v2-web November 21, 2024 14:04 Inactive
@vercel vercel bot temporarily deployed to Preview – umami-v2-web-storybook November 21, 2024 14:06 Inactive
@vercel vercel bot temporarily deployed to Preview – umami-embed-iframe-ghostnet November 21, 2024 14:07 Inactive
@vercel vercel bot temporarily deployed to Preview – umami-embed-iframe November 21, 2024 14:07 Inactive
@ajinkyaraj-23 ajinkyaraj-23 merged commit 01676c7 into main Nov 21, 2024
10 checks passed
@ajinkyaraj-23 ajinkyaraj-23 deleted the ajinkyaraj-23@add-ci branch November 21, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants