Add SecurityWarningModal to the layout page #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OKendigelyan
force-pushed
the
add-security-warning-modal
branch
from
af3e0a8 to
798da10
Compare
OKendigelyan
force-pushed
the
add-security-warning-modal
branch
from
798da10 to
4d26c9d
Compare
asiia-trilitech
approved these changes
Nov 8, 2024
| const [openedAccordionItems, setOpenedAccordionItems] = useState<Set<number>>(new Set()); | ||
|
|
||
| const handleInform = () => { | ||
| localStorage.setItem("user:isInformed", "true"); |
There was a problem hiding this comment.
maybe user:isExtensionsWarningShown?
| it("renders all accordion items", async () => { | ||
| await renderInModal(<SecurityWarningModal />); | ||
|
|
||
| accordionItems.forEach(({ title }) => { |
There was a problem hiding this comment.
nit: can we have an array of titles here instead?
If there is a fault with the accordionItems this test will still be green.
| expect(gotItButton).toBeEnabled(); | ||
| }); | ||
|
|
||
| it("sets localStorage and closes modal when 'Got it' is clicked", async () => { |
There was a problem hiding this comment.
nit: would be better to split into two separate tests, the more simple unit test is - the better
OKendigelyan
force-pushed
the
add-security-warning-modal
branch
from
8daea34 to
26f9a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Checklist