Implement AddContactModal #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OKendigelyan
force-pushed
the
add-add-contact-modal
branch
from
8f56e0c to
f2b2190
Compare
asiia-trilitech
requested changes
Nov 8, 2024
| import { ModalCloseButton } from "../CloseButton"; | ||
|
|
||
| export const AddContactModal: FC<{ | ||
| pkh?: string; |
There was a problem hiding this comment.
I think we only use AddContactModal with preset pkh on web - so maybe we can make pkh required & remove some extra code & tests ?
(for new contacts we use button in the settings drawer)
OKendigelyan
force-pushed
the
add-add-contact-modal
branch
from
f2b2190 to
a2773e4
Compare
OKendigelyan
force-pushed
the
add-add-contact-modal
branch
from
a2773e4 to
d4645ac
Compare
OKendigelyan
force-pushed
the
add-add-contact-modal
branch
from
a0b2a12 to
8fe0c6e
Compare
asiia-trilitech
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist