Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite scroll on Operations and Activity pages #2035

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix infinite scroll on Operations and Activity pages #2035

merged 2 commits into from
Oct 31, 2024

Conversation

OKendigelyan
Copy link
Contributor

@OKendigelyan OKendigelyan commented Oct 31, 2024 •
edited
Loading

Proposed changes

This PR fixes infinite scroll on web

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
test-umami-embed-tb-deleted ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:21pm
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:21pm
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:21pm
umami-embed-iframe-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:21pm
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:21pm
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:21pm

@OKendigelyan OKendigelyan marked this pull request as ready for review October 31, 2024 14:31
@OKendigelyan OKendigelyan force-pushed the fix-operations-infinite-scroll branch from 6ba5b91 to 95c96aa Compare October 31, 2024 14:37
@OKendigelyan OKendigelyan force-pushed the fix-operations-infinite-scroll branch from 95c96aa to 3a62da6 Compare October 31, 2024 14:57
@OKendigelyan OKendigelyan force-pushed the fix-operations-infinite-scroll branch from 3a62da6 to ac5530f Compare October 31, 2024 15:08
@OKendigelyan OKendigelyan force-pushed the fix-operations-infinite-scroll branch from ac5530f to c12f939 Compare October 31, 2024 15:17
@OKendigelyan OKendigelyan merged commit 8c8e472 into main Oct 31, 2024
11 checks passed
@OKendigelyan OKendigelyan deleted the fix-operations-infinite-scroll branch October 31, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serjonya-trili serjonya-trili serjonya-trili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OKendigelyan @serjonya-trili