feat: Adding WalletConnect data to peer list and slices #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dianasavvatina
force-pushed
the
add-wc-connect
branch
3 times, most recently
from
22d7d7c to
275ec93
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
f5056e3 to
9ccff4e
Compare
dianasavvatina
force-pushed
the
add-wc-connect
branch
2 times, most recently
from
000c6e6 to
ffcbede
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
9ccff4e to
933a358
Compare
dianasavvatina
force-pushed
the
add-wc-connect
branch
from
ffcbede to
57cab82
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
933a358 to
6143329
Compare
dianasavvatina
changed the title
9 tasks
dianasavvatina
force-pushed
the
add-wc-connect
branch
from
57cab82 to
518f01d
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
6143329 to
218a881
Compare
dianasavvatina
force-pushed
the
add-wc-connect
branch
from
518f01d to
e0c47d8
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
218a881 to
c8d3c92
Compare
dianasavvatina
force-pushed
the
add-wc-connect
branch
from
e0c47d8 to
b15dbc5
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
c8d3c92 to
a18d63b
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
d6dd527 to
d8c435c
Compare
OKendigelyan
approved these changes
Dec 2, 2024
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
1182142 to
bb35966
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
bb35966 to
cb9cff3
Compare
dianasavvatina
force-pushed
the
add-wc-slice
branch
from
cb9cff3 to
2427dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding peers for WalletConnect
Types of changes
Steps to reproduce
Rejecting
actions: on dApp - connect, copy link. on Wallet: Connect, reject
result: on Wallet - Approve button is inactive. On reject - modal is closed immediately. on dApp: modal is closed
Approving
actions: on dApp - connect, copy link. on Wallet: on Wallet: Connect, select Account, Approve
result: on dApp - connected, the list of actions is shown. on Wallet: the modal is closed, the list of peers contains the dApp (name, account, network, button to disconnect)
actions: on dApp - request transaction
result: on dApp - transaction is immediately rejected with USER rejected error
Disconnecting from Wallet
actions: connect with approve; click Disconnect on Wallet
result: on Wallet: dapp is removed from the list. on Dapp - state changes to disconnected
Disconnecting from dApp
actions: connect with approve; click Disconnect on dApp
result: on Wallet: dapp is removed from the list; toast shows which dApp disconnected. on dApp - state changes to disconnected
Screenshots
Checklist