Add password for backups #1892
Merged
Add password for backups #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OKendigelyan
requested changes
Sep 16, 2024
packages/state/src/hooks/backup.ts
Outdated
| link.download = `UmamiV2Backup_${downloadedDate}.json`; | ||
|
|
||
| const currentDate = new Date().toISOString().slice(0, 10); | ||
| link.href = `data:text/json;chatset=utf-8,${encodeURIComponent(JSON.stringify(encryptedBackup))}`; |
There was a problem hiding this comment.
typo in chatset=utf-8 => charset=utf-8
packages/state/src/hooks/backup.ts
Outdated
| return restoreV2BackupFile(backup, password, persistor); | ||
| }; | ||
|
|
||
| export const downloadBackupFile = async (password: string) => { |
There was a problem hiding this comment.
Would be nice to have unit tests for this function
|
Checked manually, everything works as expected! |
serjonya-trili
force-pushed
the
protect-backup-integrity
branch
from
367af21 to
cb6cd30
Compare
OKendigelyan
approved these changes
Sep 17, 2024
serjonya-trili
force-pushed
the
protect-backup-integrity
branch
from
cb6cd30 to
e8dd2cc
Compare
serjonya-trili
force-pushed
the
protect-backup-integrity
branch
from
e8dd2cc to
8ebf20a
Compare
serjonya-trili
force-pushed
the
protect-backup-integrity
branch
from
8ebf20a to
61e16a7
Compare
serjonya-trili
force-pushed
the
protect-backup-integrity
branch
from
61e16a7 to
5628053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Task link
Types of changes
Steps to reproduce
Screenshots
Add the screenshots of how the app used to look like and how it looks now
Checklist